Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force arch for amd64 #1585

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Force arch for amd64 #1585

merged 1 commit into from
Apr 26, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 26, 2024

Summary

Currently, builds work fine if you build on an amd64 machine. If you build on an arm64 machine, it doesn't work because we are assuming the default architecture. This change forces the architecture so builds should work from anywhere.

Use Cases

Build anywhere.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Force arch for amd64
b1f348f 
Currently, builds work fine if you build on an amd64 machine. If you build on an arm64 machine, it doesn't work because we are assuming the default architecture. This change forces the architecture so builds should work from anywhere.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Apr 26, 2024
@dmikusa dmikusa requested a review from a team as a code owner April 26, 2024 14:14
@anthonydahanne anthonydahanne merged commit fb5de9c into main Apr 26, 2024
7 checks passed
@anthonydahanne anthonydahanne deleted the build-fix branch April 26, 2024 14:37
This was referenced May 10, 2024
Merged
Merged
Merged
Merged
This was referenced May 10, 2024
Open
Merged
Open
This was referenced May 10, 2024
Merged
Merged
Merged
Merged
Merged
Open
@wangeguo wangeguo mentioned this pull request May 10, 2024
Merged
This was referenced May 10, 2024
Merged
Merged
Open
Merged
Merged
Merged
Merged
This was referenced May 10, 2024
Merged
Merged
This was referenced May 10, 2024
Merged
Merged
Open
Open
Merged
Merged
@wangeguo wangeguo mentioned this pull request May 10, 2024
Merged
This was referenced May 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 10, 2024
Merged
Merged
This was referenced May 10, 2024
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
This was referenced May 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmikusa @anthonydahanne