Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit Implementation of Pipenv Buildpack #88

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Packit Implementation of Pipenv Buildpack #88

merged 1 commit into from
Apr 20, 2021

Conversation

thitch97
Copy link
Contributor

  • The pipenv cnb just installs pipenv using pip
  • It no longer converts Pipfile to requirements.txt
  • The buildpack API is as follows:
    • provides: pipenv
    • requires: cpython and pip during build

Resolves #67

Co-authored-by: Timothy Hitchener thitchener@pivotal.io
Co-authored-by: Arjun Sreedharan asreedharan@vmware.com
Co-authored-by: Brayan Henao bhenao@vmware.com

- The pipenv cnb just installs pipenv using pip
- It no longer converts Pipfile to requirements.txt
- The buildpack API is as follows:
- - provides: pipenv
- - requires: cpython and pip during build

Resolves #67

Co-authored-by: Timothy Hitchener <thitchener@pivotal.io>
Co-authored-by: Arjun Sreedharan <asreedharan@vmware.com>
Co-authored-by: Brayan Henao <bhenao@vmware.com>
@thitch97 thitch97 requested a review from a team April 20, 2021 14:57
@arjun024 arjun024 merged commit 2e7ec81 into main Apr 20, 2021
@arjun024 arjun024 deleted the packit-rewrite branch April 20, 2021 15:02
@robdimsdale robdimsdale added the semver:minor A change requiring a minor version bump label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure: rewrite pipenv buildpack
3 participants