Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET 8.0 #145

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Support .NET 8.0 #145

merged 1 commit into from
Nov 20, 2023

Conversation

skarllot
Copy link
Contributor

The issue or feature being addressed

Ensure that Jab is compatible with .NET 8.0 SDK.

Details on the issue fix or feature implementation

Add target to .NET 8.0 for testing and benchmarking projects.

src/Jab/Attributes.cs Outdated Show resolved Hide resolved
@skarllot
Copy link
Contributor Author

@pakrym not sure what is wrong with Pack step

@skarllot
Copy link
Contributor Author

I found the problem. It is because .NET 8.0 packs using Release configuration that is not built.

@pakrym pakrym merged commit f682bc7 into pakrym:main Nov 20, 2023
4 checks passed
@pakrym
Copy link
Owner

pakrym commented Nov 20, 2023

Thank you @skarllot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants