Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore private methods and non-settable properties #27

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

felixdesouza
Copy link
Contributor

Before this PR

If you had an abstract class with private methods or public methods with parameters, it would try to start assigning those fields even though it doesn't make any sense.

After this PR

==COMMIT_MSG==
Stricter filtering on what is and isn't settable.
==COMMIT_MSG==

Now we ensure that for a method to be assigned it:

  • is not private
  • is a zero arg method
  • it's either nested
  • or it is settable i.e. derives from some sort of Property, had to include ConfigurableFilesCollection as I had missed that last time round.

Possible downsides?

It feels very whack-a-mole. It gets us to our goal of more parallelisable things, but I wonder whether we can do a two-pronged approach with trying to attack the configuration cache (which supposedly gets you parallel runs for free as well).

@changelog-app
Copy link

changelog-app bot commented Apr 14, 2023

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Stricter filtering on what is and isn't settable.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 40aefda into develop Apr 14, 2023
@bulldozer-bot bulldozer-bot bot deleted the better-filtering branch April 14, 2023 10:38
@svc-autorelease
Copy link
Collaborator

Released 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants