ignore private methods and non-settable properties #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
If you had an abstract class with private methods or public methods with parameters, it would try to start assigning those fields even though it doesn't make any sense.
After this PR
==COMMIT_MSG==
Stricter filtering on what is and isn't settable.
==COMMIT_MSG==
Now we ensure that for a method to be assigned it:
Property
, had to includeConfigurableFilesCollection
as I had missed that last time round.Possible downsides?
It feels very whack-a-mole. It gets us to our goal of more parallelisable things, but I wonder whether we can do a two-pronged approach with trying to attack the configuration cache (which supposedly gets you parallel runs for free as well).