Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[landing] fix alignment, pause animation when offscreen #2219

Merged
merged 6 commits into from
Mar 9, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2218

Changes proposed in this pull request:

  • 🙌 pause logo animation when offscreen to avoid scrolling performance impact.
  • refactor Animator: add stop() & isRunning() & add()
  • enable TSLint for logo

Gilad Gray added 3 commits March 9, 2018 10:15
to avoid scrolling performance impact.
add Animator stop() & isRunning() & add()
@@ -259,7 +259,6 @@ header {
}

.pt-button {
display: inline-block;
Copy link
Contributor Author

@giladgray giladgray Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for #2218: buttons use flex now

@blueprint-bot
Copy link

enable linting for logo

Preview: documentation | landing | table

@blueprint-bot
Copy link

refactor block groups config

Preview: documentation | landing | table

@blueprint-bot
Copy link

bring back Animator shorthand methods with private add impl (to reduce whitespace changes)

Preview: documentation | landing | table

@giladgray giladgray merged commit cc3781e into develop Mar 9, 2018
@giladgray giladgray deleted the gg/landing branch March 9, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants