[landing] fix alignment, pause animation when offscreen #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2018 10:15
to avoid scrolling performance impact. add Animator stop() & isRunning() & add()
giladgray
commented
Mar 9, 2018
| @@ -259,7 +259,6 @@ header { | |||
| } | |||
|
|
|||
| .pt-button { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
fix for #2218: buttons use flex now
enable linting for logoPreview: documentation | landing | table |
adidahiya
approved these changes
Mar 9, 2018
refactor block groups configPreview: documentation | landing | table |
…e whitespace changes)
bring back Animator shorthand methods with private add impl (to reduce whitespace changes)Preview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2218
Changes proposed in this pull request:
Animator: addstop()&isRunning()&add()