Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icon "floating-point" #5309

Merged
merged 2 commits into from
May 19, 2022

Conversation

float-icon
Copy link
Contributor

Fixes #0000

Checklist

  • Update documentation

Changes proposed in this pull request:

Adds a float icon reading "1.0".

Screenshot

20px_float
16px_float

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @float-icon! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVGs look good, but I'd like to change the metadata

packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
@float-icon float-icon requested a review from adidahiya May 19, 2022 09:35
@float-icon
Copy link
Contributor Author

SVGs look good, but I'd like to change the metadata

done

@adidahiya adidahiya changed the title feat: new icon - float [icons] feat: new icon "floating-point" May 19, 2022
@adidahiya adidahiya merged commit d2073b4 into palantir:develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants