Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Menu): add a11y roles and aria attributes #5326

Merged
merged 6 commits into from
May 26, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #5320

Checklist

  • [N/A ] Includes tests
  • [N/A] Update documentation

Changes proposed in this pull request:

Fix Menu and MenuItem a11y roles for a menu per this example: https://w3c.github.io/aria-practices/examples/menubar/menubar-navigation.html

Reviewers should focus on:

the above example aria menu

@bvandercar-vt
Copy link
Contributor Author

I am on Windows 10 and am getting errors when running yarn verify/yarn compile, and cannot run yarn test either-- can one of the Devs please check out this branch and run the test I've written plus whatever else needs to be done?

@adidahiya
Copy link
Contributor

Thanks for your contributions, and sorry about the trouble building the project on Windows. Could you share some of your build errors in this issue? Other contributors have had similar problems: #4221

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good, just one small comment

@adidahiya adidahiya changed the title fix(a11y): fix menu a11y roles [core] fix(Menu): add a11y roles and aria attributes May 26, 2022
@adidahiya adidahiya merged commit 7b6d16a into palantir:develop May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ability to modify the li props in a MenuItem in order to create a proper a11y menu
2 participants