[core] fix(OverflowList): improve performance, allow more items #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…partition cycle to increase collapsible elements from 50 to 2^50. Fixes palantir#3792
|
Thanks for your interest in palantir/blueprint, @matt-gold! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
changed the title
adidahiya
reviewed
Jun 16, 2022
Comment on lines
+117
to
+119
| /** Pointer for the binary search algorithm used to find the finished non-overflowing state */ | ||
| chopSize: number; | ||
| lastChopSize: number | null; |
There was a problem hiding this comment.
I don't think either of these need to live in state, they can just be private members of the component class. They are not referenced in any lifecycle method, just repartition(), so it should be save to move out of state.
There was a problem hiding this comment.
This is not a huge deal, though, so I can fix it in a follow-up PR if necessary. Thanks for the contribution @matt-gold!
adidahiya
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use binary search instead of sequential search in the OverflowList repartition cycle to increase collapsible elements from 50 to 2^50.
Fixes #3792
Checklist
Changes proposed in this pull request:
This pull request changes the algorithm used to repartition the OverflowList so that it can support a much higher number of items. The previous overflow list would break if there were 50 or more items collapsed into the Overflow element as described in issue #3792.
Reviewers should focus on:
The new OverflowList partitioning logic.