Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] feat(Table2, ColumnHeaderCell2): migrate away from legacy React context API #5491

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

adidahiya
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Remove contextTypes and getChildContext() from <Table2>
  • Add enableColumnInteractionBar prop to <ColumnHeaderCell2>, plumb the prop through from <Table2> instead of using React context API (it was unnecessarily complex in the first place to use context)

@blueprint-bot
Copy link

[table] feat(Table2, ColumnHeaderCell2): migrate away from legacy context API

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

Fix test

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit eb33181 into develop Aug 8, 2022
@adidahiya adidahiya deleted the ad/table2-legacy-context branch August 8, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants