Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datetime2] feat(TimezoneSelect): allow filtering by short names #5532

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

vhellem
Copy link
Contributor

@vhellem vhellem commented Sep 8, 2022

Partially fixes #5531 by allowing you to search for the short name. This is locale specific and abbreviations may differ depending on your browser locale.

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

allow earching forabbreviations in TimezonePicker

Reviewers should focus on:

  • Whether we need to update any tests/documentation here.

Screenshot

Screenshot 2022-09-08 at 10 50 50

@blueprint-bot
Copy link

Empty commit to trigger build

Previews: documentation | landing | table | demo

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works in the docs preview, lgtm 👍

@adidahiya adidahiya changed the title Allow search for shortnames [datetime2] feat(TimezoneSelect): allow filtering by short names Sep 8, 2022
@adidahiya adidahiya merged commit e33eb93 into develop Sep 8, 2022
@adidahiya adidahiya deleted the vhellem/search_for_abbreviation_dateinput2 branch September 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimezoneSelect should allow searching by abbreviation
3 participants