[popover2] fix(Popover2): renderTarget typedef regression #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default type paramsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
clean up typesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
commented
Jan 31, 2023
| @@ -568,13 +568,7 @@ export const DateInput2: React.FC<DateInput2Props> = React.memo(function _DateIn | |||
|
|
|||
| // We use the renderTarget API to flatten the rendered DOM and make it easier to implement features like the "fill" prop. | |||
| const renderTarget = React.useCallback( | |||
| // N.B. pull out `defaultValue` so that it's not forwarded to the DOM. | |||
There was a problem hiding this comment.
note that this is another benefit of the type changes in #5802 -- we no longer have to deal with extraneous props which are not actually passed to the target renderer, but were presumed to exist in the previous type definitions 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5889
Checklist
Changes proposed in this pull request:
&type union instead of OR|to allow access to common props passed torenderTargetTooltip2(this should fix the linked issue)Reviewers should focus on:
No regressions, and the new unit test is appropriate