Actually update aria-hidden in Collapse #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually update aria-hidden in CollapseBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
approved these changes
Feb 7, 2023
shim-flounce
added a commit
to shim-flounce/blueprint
that referenced
this pull request
Feb 15, 2023
This fixes regression introduced in palantir#5926 where if `keepChildrenMounted` is set, `aria-hidden` no longer updates correctly.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reproducible in the blueprint docs - if you open/close the collapse, aria-hidden doesn't actually change:
I think it's because
aria-hiddenshould reflect whether we're actually hiding children or not?