[select] fix(Select2): check shouldDismissPopover on menu items #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickBrown1
changed the title
fix default to closeBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
removed unneeded commentBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
approved these changes
Apr 17, 2023
adidahiya
changed the title
|
It looks like this has broken the default dismissal behavior of TimezoneSelect items:
it should be:
|
|
strike that -- this PR didn't break it, it actually surfaced current buggy behavior. we're specifying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4001
Checklist
Don't see a need to update docs because it fixes a feature that should be working.
Changes proposed in this pull request:
Fixes problem where popover was closing on selection despite shouldDismissPopover being set to false on MenuItem2.
Reviewers should focus on:
Ensuring popover open state is updated correctly
Screenshot
N/A