Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceExceptionAssert.hasCode #1103

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add ServiceExceptionAssert.hasCode #1103

merged 2 commits into from
Feb 13, 2024

Conversation

pkoenig10
Copy link
Member

We have an internal library with methods that throw ServiceException with ErrorType.PERMISSION_DENIED. However , in order us flexibility to evolve this API, we don't guarantee that these methods will always use ErrorType.PERMISSION_DENIED, only that the error code will be ErrorType.Code.PERMISSION_DENIED. It would be nice if consumers of this library could make assertions about just the ErrorType.Code of a ServiceException.

Ultimately we may want something similar for RemoteExceptionAssert, but I don't have a concrete use case so it's unclear what the API should be given that RemoteException has both an errorCode and status.

@changelog-app
Copy link

changelog-app bot commented Feb 13, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add ServiceExceptionAssert.hasCode to assert the ErrorType.Code of a ServiceException.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bulldozer-bot bulldozer-bot bot merged commit d4c1610 into develop Feb 13, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig/code branch February 13, 2024 15:19
@svc-autorelease
Copy link
Collaborator

Released 2.48.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants