Add ServiceExceptionAssert.hasCode #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an internal library with methods that throw
ServiceException
withErrorType.PERMISSION_DENIED
. However , in order us flexibility to evolve this API, we don't guarantee that these methods will always useErrorType.PERMISSION_DENIED
, only that the error code will beErrorType.Code.PERMISSION_DENIED
. It would be nice if consumers of this library could make assertions about just theErrorType.Code
of aServiceException
.Ultimately we may want something similar for
RemoteExceptionAssert
, but I don't have a concrete use case so it's unclear what the API should be given thatRemoteException
has both anerrorCode
andstatus
.