Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bean map fields should not allow null values #291

Open
carterkozak opened this issue Mar 21, 2019 · 1 comment
Open

Bean map fields should not allow null values #291

carterkozak opened this issue Mar 21, 2019 · 1 comment

Comments

@carterkozak
Copy link
Contributor

What happened?

MapExample.builder().items("foo", null).build() produces MapExample{items: {foo=null}}

What did you want to happen?

I expected a SafeNullPointerException("value cannot be null") to be thrown
carterkozak added a commit to palantir/conjure-java-runtime that referenced this issue Mar 21, 2019
@carterkozak
Relax CollectionValidationModule map validation to match generated ob…
e4f9dcb 
…jects

Null map values no longer trigger WARN logging or assertions.
Tracking conjure-java failure to validate null map values here:
palantir/conjure-java#291
@carterkozak carterkozak mentioned this issue Mar 21, 2019
Merged
@jroitgrund
Copy link

If reimplementing this, can we add a test to make sure we handle Optionals correctly? palantir/conjure-java-runtime#997

@Alexis-D Alexis-D mentioned this issue Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jroitgrund @carterkozak