publish conjure-core cli #21
Conversation
| @@ -1,5 +1,6 @@ | |||
| rootProject.name = 'conjure' | |||
|
|
|||
| include 'conjure' | |||
There was a problem hiding this comment.
none of the other clis include cli in their name. I'm following that convention, but again its not been hard decided
There was a problem hiding this comment.
just to clear, so we will have
`conjure` for parser
`conjure-<language>` for language specific generators
can you update the readme to reflect this?
|
|
||
| @Value.Immutable | ||
| public abstract class CliConfiguration { | ||
| abstract Collection<File> inputFiles(); |
There was a problem hiding this comment.
why not make this a target?
There was a problem hiding this comment.
and lazily derived a list of files from the target path?
There was a problem hiding this comment.
not sure what the value is. We use the input files pretty much immediately
| @@ -0,0 +1,63 @@ | |||
| /* | |||
| @@ -1,5 +1,6 @@ | |||
| rootProject.name = 'conjure' | |||
|
|
|||
| include 'conjure' | |||
There was a problem hiding this comment.
just to clear, so we will have
`conjure` for parser
`conjure-<language>` for language specific generators
can you update the readme to reflect this?
| static CliConfiguration of(String target, String outputDirectory) throws IOException { | ||
| File input = new File(target); | ||
|
|
||
| Collection<File> inputFiles = ImmutableList.of(input); |
There was a problem hiding this comment.
do we care if input exists?
There was a problem hiding this comment.
it will fail when it tries to parse
| if (input.isDirectory()) { | ||
| try (Stream<Path> fileStream = Files.find(input.toPath(), 999, (path, bfa) -> bfa.isRegularFile())) { | ||
| inputFiles = fileStream | ||
| .map(path -> new File(path.toAbsolutePath().toString())) |
gradle/publish-dist.gradle
Outdated
| apply plugin: 'maven-publish' | ||
|
|
||
| distTar.compression = Compression.GZIP | ||
| distZip.enabled = false |
There was a problem hiding this comment.
curious why this is needed?
There was a problem hiding this comment.
its not was just copied from conjure-java
|
I think the naming looks good here. Long term, I think it would be kinda cool if people could just |
|
i like that vision, we should then add a sub-command called |
|
Especially because this would let people try out conjure in a super user-friendly way, without having to faff with publishing or gradle etc etc. For an MVP, they can just write some yml files, run the CLI to generate some java & typescript and then check in those generated files. I think this would get people off the ground super super fast (even if it has the downsides that it's not as nicely reproducible for other contributors) |
Publish standalone conjure-cli. Stepping stone towards full Java10 cli