[fix] Aliases are now allowed in path and query parameters #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferozco
reviewed
Aug 29, 2018
| .map(entry -> entry.getValue().visit( | ||
| new TypeDefinitionParserVisitor(entry.getKey().name(), defaultPackage, typeResolver))) | ||
| .collect(Collectors.toList())) | ||
| .build(); | ||
| .collect(toImmutableMap(td -> td.accept(TypeDefinitionVisitor.TYPE_NAME), td -> td)); |
There was a problem hiding this comment.
why can't we just use the regular collector
ferozco
previously approved these changes
Aug 29, 2018
dansanduleac
changed the title
dansanduleac
changed the title
iamdanfox
approved these changes
Aug 30, 2018
|
hey folks, can we please get a release with this? blocking /f/comments/pull/427 / /f/comments/pull/396 |
|
Happy to release but please try to avoid adding internal links to external github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #37 (release 4.0.1)
Fixes #61
Implementation
Add ConjureContextualValidator concept - when validating, it's also given a
DealiasingTypeVisitorthat can be used to find the de-aliased Type (it's traversed through the object definitions until you find a type that's not a reference type).The
DealiasingTypeVisitortakes the parsed version of the conjure yml types block, in the form of aMap<TypeName, TypeDefinition>, in order to resolve references.