Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Manage go module dependencies #98

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the go/manage-go-mod-dependencies-oss check.

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the go/manage-go-mod-dependencies-oss branch 2 times, most recently from e4dbe77 to 5d7144e Compare August 27, 2021 09:51
github.com/shurcooL/githubv4 v0.0.0-20191127044304-8f68eb5628d0
github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475
github.com/rs/zerolog v1.24.0
github.com/shurcooL/githubv4 v0.0.0-20210725200734-83ba7b4c9228
Copy link
Member

@asvoboda asvoboda Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this contains a lot of changes. How many of them are going to be breaks?https://docs.github.com/en/graphql/overview/changelog https://docs.github.com/en/graphql/overview/breaking-changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because GraphQL queries are defined by applications, I think any applications impacted by these breaks would have already encountered them. The githubv4 library's only coupling with the API is the helper types it defines, so some of those could have been removed or changed, but I'd expect queries using them are already broken.

@asvoboda asvoboda merged commit b498681 into develop Sep 9, 2021
@asvoboda asvoboda deleted the go/manage-go-mod-dependencies-oss branch September 9, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants