-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to input Directory in files #115
Comments
was hoping if there's a way to keep the directory format without unpacking it into a list of files in build/docker |
Can you expand on this: what's the configuration you're trying and in what
way does it not behave as expected?
…On Thu, Feb 16, 2017 at 12:23 PM Claire Keum ***@***.***> wrote:
was hoping if there's a way to keep the directory format without unpacking
it into a list of files in build/docker
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGOdwTDxt5paU5LawJql3pzPg-NpklIdks5rdLBHgaJpZM4MDfqO>
.
|
Here's an example. When we have something like Files in dirName directory gets unpacked into a list of files under build/docker. However, there are some use cases I could think of, where we keep multiple scripts together, or jar files together in a directory, in which would allow us to simply copy that directory into the docker image. There's a workaround to this, which is by creating another layer of directory under a directory- Thought that 'files' maintaining its format (if is a directory, whole directory be included in docker context and if a file, just a file be included in) would be useful. |
Agree. Are you willing to provide a failing test
in PalantirDockerPluginTests?
…On Thu, Feb 16, 2017 at 4:42 PM Claire Keum ***@***.***> wrote:
Here's an example.
When we have something like
docker {
...
files 'dirName'
}
Files in dirName directory gets unpacked into a list of files under
build/docker. However, there are some use cases I could think of, where we
keep multiple scripts together, or jar files together in a directory, in
which would allow us to simply copy that directory into the docker image.
There's a workaround to this, which is by creating another layer of
directory under a directory-
Thought that 'files' maintaining its format (if is a directory, whole
directory be included in docker context and if a file, just a file be
included in) would be useful.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGOdwfSIuawBxcLKO1zyC3shCYHYy98Qks5rdOztgaJpZM4MDfqO>
.
|
Yes sure. I'll create a PR soon. |
Closed by #123 |
No description provided.
The text was updated successfully, but these errors were encountered: