Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 4.4 support #157

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Gradle 4.4 support #157

merged 1 commit into from
Dec 19, 2017

Conversation

kyegupov
Copy link
Contributor

Internal APIs have changed for UsageContext and Usage, so quite a bunch of changes were needed to adapt to that.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-docker, @kyegupov! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@uschi2000
Copy link
Contributor

I'm fine with this. The alternative would to remove the support for docker dependencies, not sure anyone uses this? @jared2501 @gracew

@jared2501
Copy link

No where ended up taking the docker dependencies stuff as far as I know

@gracew
Copy link

gracew commented Dec 15, 2017

I think we use docker dependencies incorrectly in a bunch of places. I'm fine with either merging this or deleting DockerComponent.

@billbindi
Copy link

I can tell you that we do in fact use this and I would appreciate this remaining, but just upgrading (i.e. merging this pr) for the newer gradle APIs.

@uschi2000
Copy link
Contributor

OK, too bad.

@uschi2000
Copy link
Contributor

thanks @kyegupov

@uschi2000 uschi2000 merged commit cc695a0 into palantir:develop Dec 19, 2017
@billbindi
Copy link

@uschi2000 it looks like this has had some troubles publishing. Judging by the gradle plugin page (https://plugins.gradle.org/plugin/com.palantir.docker) it hasn't published since 0.13.0. This most recent one looks like a test failure, which is odd since the pr passed that test just fine. Any chance you could try a retrigger to see if it is just a flickering test?

@uschi2000
Copy link
Contributor

uschi2000 commented Dec 22, 2017 via email

@uschi2000
Copy link
Contributor

0.17.0 is now on bintray. docker plugin portal publishing is still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants