-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle 4.4 support #157
Gradle 4.4 support #157
Conversation
Thanks for your interest in palantir/gradle-docker, @kyegupov! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
I'm fine with this. The alternative would to remove the support for docker dependencies, not sure anyone uses this? @jared2501 @gracew |
No where ended up taking the docker dependencies stuff as far as I know |
I think we use docker dependencies incorrectly in a bunch of places. I'm fine with either merging this or deleting |
I can tell you that we do in fact use this and I would appreciate this remaining, but just upgrading (i.e. merging this pr) for the newer gradle APIs. |
OK, too bad. |
thanks @kyegupov |
@uschi2000 it looks like this has had some troubles publishing. Judging by the gradle plugin page (https://plugins.gradle.org/plugin/com.palantir.docker) it hasn't published since |
Working on it.
|
0.17.0 is now on bintray. docker plugin portal publishing is still broken. |
Internal APIs have changed for UsageContext and Usage, so quite a bunch of changes were needed to adapt to that.