Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] generateDockerCompose re-runs if template tokens change #242

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

a10y
Copy link
Contributor

@a10y a10y commented Apr 17, 2019

Fixes #226

Allows regenerating files when the template tokens change.

Still needs test

Before this PR

After this PR

Allows regenerating files when the template tokens change.
@a10y a10y requested a review from a team as a code owner April 17, 2019 19:13
@iamdanfox iamdanfox changed the title Add template tokens as task input [fix] generateDockerCompose re-runs if template tokens change Apr 17, 2019
@a10y
Copy link
Contributor Author

a10y commented Apr 18, 2019

There's no unit test suite for the GenerateDockerComposeTask, but I tested locally via publishToMavenLocal that

  1. Make a docker-compose.template.yml file with a templateToken based on the git version
  2. Make a commit
  3. ./gradlew generateDockerCompose outputs docker-compose.yml with git version
  4. Make another commit
  5. ./gradlew generateDockerCompose rewrites docker-compose.yml with new git version

@iamdanfox iamdanfox merged commit 1045fd7 into palantir:develop Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateDockerCompose should replace generated docker-compose if already exists
2 participants