Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose down #297

Merged
merged 5 commits into from
Jan 14, 2020
Merged

Conversation

tkgregory
Copy link
Contributor

Before this PR

There was no ability to call docker compose down from the Gradle plugin

After this PR

==COMMIT_MSG==
New dockerComposeDown Gradle task available in Docker Compose plugin.
==COMMIT_MSG==

Possible downsides?

None

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-docker, @tkgregory! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@policy-bot policy-bot bot requested a review from ferozco December 8, 2019 22:05
@stale
Copy link

stale bot commented Dec 22, 2019

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Dec 22, 2019
@tkgregory
Copy link
Contributor Author

@ferozco are you able to take a look at this? Please advise how to proceed.

@stale stale bot removed the stale label Dec 27, 2019
@stale
Copy link

stale bot commented Jan 10, 2020

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale bot added the stale label Jan 10, 2020
@tkgregory
Copy link
Contributor Author

Bump

@stale stale bot removed the stale label Jan 11, 2020
@ferozco
Copy link
Contributor

ferozco commented Jan 14, 2020

Thanks Tom! sorry for the delay in reviewing

@ferozco
Copy link
Contributor

ferozco commented Jan 14, 2020

Looks like the bots can't generate a changelog because the head of the PR is on your fork. Can you manually add a changelog?

@tkgregory
Copy link
Contributor Author

Hi @ferozco I added a changelog but the check is still failing. Do you know exactly what is expected please?

@ferozco
Copy link
Contributor

ferozco commented Jan 14, 2020

🤦‍♂ looks like this repo hasn't been migrated to use structured changelogs yet. I'll follow up and clean this up

@bulldozer-bot bulldozer-bot bot merged commit 4729afd into palantir:develop Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants