Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use gradle internal ArchivePublishArtifact #638

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

sanggggg
Copy link
Contributor

@sanggggg sanggggg commented Apr 3, 2023

Before this PR

Plugin is not compatible with gradle version upper 8.0 #618

After this PR

Gradle plugin can't use internal class ArchivePublishArtifact anymore upper 8.0. JetBrains/intellij-platform-gradle-plugin#1272
Do not use internal class ArchivePublishArtifact directly, instead make artifact with recommended API.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/gradle-docker, @sanggggg! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bulldozer-bot bulldozer-bot bot merged commit c00e973 into palantir:develop Apr 3, 2023
@svc-autorelease
Copy link
Collaborator

Released 0.35.0

@sanggggg sanggggg deleted the fix-gradle-8-conflict branch April 4, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants