Fix typo in the load flag getter/setters #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/gradle-docker, @shacker27! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
Looks good once CLA is signed @shacker27 😃 |
|
@schlosna just signed today! Thank you! |
schlosna
approved these changes
Mar 2, 2024
|
Released 0.36.0 |
|
Thanks @shacker27 for the contribution! A release 0.36.0 should be published shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
It seems like there was a typo in the getter/setter for the
loadvariable. I noticed this when I was trying to set up buildx multi-architecture publishing and getting errors about having bothloadandpushset, even though I was explicitly settingloadtofalse.After this PR
==COMMIT_MSG==
Fix typo in the load flag getter/setters
==COMMIT_MSG==
Possible downsides?