Produce Palantir CA Plugin #161
Conversation
Generate changelog in
|
| private static final BigInteger PALANTIR_3RD_GEN_SERIAL = new BigInteger("18126334688741185161"); | ||
|
|
||
| public static void applyToRootProject(Project rootProject, boolean strict) { |
There was a problem hiding this comment.
should strict still not be configurable via some extension? the failures will effectively be silent as most builds don't run with --info ?
There was a problem hiding this comment.
We want the failures to be silent, at least on open source, as external contributors who do not have the palantir CA in their truststore need to run the code.
There was a problem hiding this comment.
Notable: public circleci
There was a problem hiding this comment.
Internally, it's a different matter - maybe it's good to have this explode if it can't find the cert. However, people shouldn't really be anything other than our internal mirror anyway. We'd probably need to have support for windows if we did do this.
There was a problem hiding this comment.
Maybe we should warn rather than info internally, so at least it's obvious...
There was a problem hiding this comment.
It now has configurable log levels, which we can set to warn internally, so people will bug us if this starts to fail at least rather than going unnoticed.
…antir/gradle-jdks into callumr/actually-include-palantir-ca
|
Released 0.29.0 |
Before this PR
We had a class that enabled other plugins to call it and it would include the Palantir corporate CA cert into JDKs, if it exists in the system truststore. This enables people to run tests in open source projects that hit public webservers from within the corporate VPN.
However, none of the other plugins (
gradle-jdks-latestorgradle-jdks-internal) actually enable this.After this PR
We now produce a plugin rather than a class so multiple other plugins can apply it without worrying if it's already been applied.
==COMMIT_MSG==
Produce
com.palantir.jdks.palantir-caplugin for use by other Gradle plugins to enable using open source projects from within the corporate VPN.==COMMIT_MSG==
Possible downsides?