Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-sealed modifier #671

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

levlukacs
Copy link
Contributor

Formatter crashed when encountering non-sealed modifiers.

Bug was also present in google-java-format.

See:
google/google-java-format#696
google/google-java-format@621fb85

@palantirtech
Copy link
Member

Thanks for your interest in palantir/palantir-java-format, @lukelukes! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Mar 14, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Handle non-sealed modifier

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from carterkozak March 14, 2022 10:51
Copy link
Contributor

@fawind fawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@fawind fawind merged commit 2f07652 into palantir:develop Mar 24, 2022
@svc-autorelease
Copy link
Collaborator

Released 2.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants