Upgrade and Update #3439
Closed
Upgrade and Update #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade jquery to 3.0.0 for security purposes Switch to es2015 module export
adidahiya
suggested changes
Feb 12, 2018
| @@ -3,12 +3,15 @@ | |||
| "declaration": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "importHelpers": true, | |||
| "module": "commonjs", | |||
| "module": "es2015", | |||
There was a problem hiding this comment.
this is a breaking change. although webpack 3 can handle es2015 modules fine, users may be using other tools that can't. if you want to make this change, it needs to be additive. blueprint publishes both commonjs and es2015 modules in the same NPM package.
There was a problem hiding this comment.
Okay, we don't need to do this for the jquery removal anyway, so I'm going to separate these steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to typescript 2.3.4
Switch to es2015 module export
Upgrade jquery to 3.0.0 for security purposes