Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Rendering Inner Loop #3470

Merged
merged 2 commits into from
May 31, 2018
Merged

Optimize Rendering Inner Loop #3470

merged 2 commits into from
May 31, 2018

Conversation

themadcreator
Copy link
Contributor

@themadcreator themadcreator commented May 30, 2018 •
edited
Loading

  • Move concats out of inner loop for resolving attributes.
  • Memoize AttrToProjector lookups.
  • Increased bar count in canvas_bars quicktest to 100K to more easily see perf changes.
  • Custom memoize cache implementation for faster 2D index lookup.

Initial local testing indicates 12 - 21% speedup in render.

@blueprint-bot
Copy link

Memoize AttrToProjector. Move concats out of inner loop.

Demo: quicktests | fiddle

@themadcreator
Copy link
Contributor Author

Also added feature flag (default false) for this memoization

@blueprint-bot
Copy link

Merge remote-tracking branch 'origin/develop' into bd/memoize-accessor

Demo: quicktests | fiddle

@themadcreator themadcreator merged commit 3335c2c into develop May 31, 2018
@themadcreator themadcreator mentioned this pull request Jun 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themadcreator @blueprint-bot