Use dynamic category axis tick spacing #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacing is based on font size
LintDemo: quicktests | fiddle |
adidahiya
reviewed
Nov 17, 2021
src/axes/categoryAxis.ts
Outdated
| @@ -160,7 +160,7 @@ export class Category extends Axis<string> { | |||
| public getDownsampleInfo(scale: Scales.Category = <Scales.Category> this._scale, domain = scale.invertRange()): IDownsampleInfo { | |||
| // account for how shearing tightens the space between vertically oriented ticks | |||
| const shearFactor = this._tickLabelAngle === 0 ? 1 : 1 / Math.cos(this._tickLabelShearAngle / 180 * Math.PI); | |||
| const shearedMinimumWidth = Category._MINIMUM_WIDTH_PER_LABEL_PX * shearFactor; | |||
| const shearedMinimumWidth = Category._MINIMUM_WIDTH_PER_LABEL_PX * shearFactor;// + 2 * (this.tickLabelFontSize() - Label._MIN_FONT_SIZE_PX); | |||
There was a problem hiding this comment.
this looks nonfunctional, just a code comment...?
There was a problem hiding this comment.
I think that was from trying to generate the screenshots. sorry about that
uncommentDemo: quicktests | fiddle |
adidahiya
approved these changes
Nov 17, 2021
michael-yx-wu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To preview, run
yarn startand go to http://localhost:9999/quicktests/dev/index.html#functional/category_axis_label_font_sizeBefore:
After:
