Jc/verbose num of approvers needed #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Dec 5, 2018
policy/approval/approve.go
Outdated
| @@ -207,7 +207,7 @@ func (r *Rule) IsApproved(ctx context.Context, prctx pull.Context) (bool, string | |||
| return false, msg, nil | |||
| } | |||
|
|
|||
| msg := fmt.Sprintf("%s needed", numberOfApprovals(remaining)) | |||
| msg := fmt.Sprintf("%s needed (of required %d)", numberOfApprovals(remaining), r.Requires.Count) | |||
There was a problem hiding this comment.
What do you think about formatting this as 1/n approvals required? I supposed we'd have to change how numberOfApprovals works, but it might be more natural to read than the parenthetical suffix.
Related, should we update the message on L204 as well?
|
using "current/required approvals needed" messaging |
bluekeyes
approved these changes
Dec 10, 2018
| numberOfApprovals(len(candidates))) | ||
| return false, msg, nil | ||
| } | ||
|
|
||
| msg := fmt.Sprintf("%s needed", numberOfApprovals(remaining)) | ||
| msg := fmt.Sprintf("%d/%d approvals required", len(approvers), r.Requires.Count) |
There was a problem hiding this comment.
style: required vs. needed in the other message. I have a slight preference for "required", but mostly want them to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display in the policy UI how many approvals are required in total for a rule to pass.