Remove usage of pull request timeline API #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We originally used this API to have consistent ordering between comments, commits, and reviews. However, this didn't respect commit push times, so we switched to using timestamps for ordering with the switch to GraphQL. Later, we discovered that the timeline API has a random delay before commits, particularly from forks, appear in the result. This causes the bot to evaluate the status for the wrong commit, breaking the invalidate_on_push option. Instead, get commits, comments, and reviews from the pull request API, which should be up-to-date when we respond to a pull_request hook. Because all three of these sources are used in most evaluations, continue to load them with a single query instead of making separate queries for each type.
|
This also updates |
ajlake
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally used this API to have consistent ordering between comments, commits, and reviews. However, this didn't respect commit push times, so we switched to using timestamps for ordering with the switch to GraphQL. Later, we discovered that the timeline API has a random delay before commits, particularly from forks, appear in the result. This causes the bot to evaluate the status for the wrong commit, breaking the
invalidate_on_pushoption.Instead, get commits, comments, and reviews from the pull request API, which should be up-to-date when we respond to a
pull_requesthook. Because all three of these sources are used in most evaluations, continue to load them with a single query instead of making separate queries for each type.See #47 for more details. This will hopefully fix the problem, but I'll submit a separate PR that adds a check for the head commit.