Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistTar task ships source code #10

Closed
szunami opened this issue Oct 12, 2015 · 3 comments
Closed

DistTar task ships source code #10

szunami opened this issue Oct 12, 2015 · 3 comments
Labels

Comments

@szunami
Copy link

szunami commented Oct 12, 2015

The DistTar task will include source jars (files off the form *-sources.jar). This is dangerous if you are pulling in source jars, as you might accidentally be distributing proprietary source code.

@markelliot
Copy link
Contributor

This would only include source jars that are showing up as dependencies but not labeled as source jars.

Any chance you have a proposal for how one would exclude those jars? (Do we need an exclusion pattern?)

Would also love a sample problem-inducing configuration so we can write a rest.

@markelliot
Copy link
Contributor

I'd add that you can add filters that you like to configurations.main.runtime in order to remove deps you don't want.

@markelliot
Copy link
Contributor

Going to close this out, I verified that we don't arbitrarily pull source jars, but do include jars that are not correctly tagged in Ivy/Maven as source, and that this behavior is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants