JAVA_OPTS needs to be escaped

[ash211]

Especially important because Java convention for separating http.nonProxyHosts parameters is with pipes.

Setting JAVA_OPTS to this would cause you very bad times: -Dhttp.nonProxyHosts=127.0.0.1|sudo\ rm\ -rf\ /opt

I think https://github.com/palantir/gradle-java-distribution/blob/8242c733c6f0ea5361bf9d6a4c59195d2073806e/gradlew#L161 needs to quote those parameters with double-quotes

[markelliot]

gradlew doesn't run in the target environment, it's part of the gradlew distribution.

[ash211]

Then the bug must be elsewhere. Repro steps:

1. Set JAVA_OPTS to -Dhello=hi|touch my-file-here
2. Restart the service
3. Observe that my-file-here is created in the Java service's working directory

I have a service named alchemist-foundry that has a shell script located at service/bin/alchemist-foundry that looks rather similar to the gradlew script here, though with a different header:

##############################################################################
##
##  alchemist-foundry start up script for UN*X
##
##############################################################################

At the bottom that script contains these lines which seem to be where the bug is:

# Split up the JVM_OPTS And ALCHEMIST_FOUNDRY_OPTS values into an array, following the shell quoting and substitution rules
function splitJvmOpts() {
    JVM_OPTS=("$@")
}
eval splitJvmOpts $DEFAULT_JVM_OPTS $JAVA_OPTS $ALCHEMIST_FOUNDRY_OPTS

This must be used as part of the Gradle default start script task defined at https://github.com/palantir/gradle-java-distribution#packaging

[markelliot]

Ok, so it’s a bug in Gradle’s generated shell script. We could look at moving away from Gradle’s generated shell script, we probably want to do some things differently than it does anyway.

[ash211]

Specifically https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt added in commit gradle/gradle@a7a8fec

[markelliot]

@uschi2000 is tracking this one

[markelliot]

Resolved in #85. We have another couple of updates to make before releasing, but this has now been addressed.