fix(member-ordering): check getter and setter methods (#3984)

palantir · Oct 5, 2019 · df68ccf · df68ccf
1 parent 8356b58
commit df68ccf
Show file tree

Hide file tree

Showing 4 changed files with 174 additions and 74 deletions.
diff --git a/src/rules/cyclomaticComplexityRule.ts b/src/rules/cyclomaticComplexityRule.ts
@@ -66,6 +66,13 @@ export class Rule extends Lint.Rules.AbstractRule {
         );
     }
 
+    private get threshold(): number {
+        if (this.ruleArguments[0] !== undefined) {
+            return this.ruleArguments[0] as number;
+        }
+        return Rule.DEFAULT_THRESHOLD;
+    }
+
     public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
         return this.applyWithFunction(sourceFile, walk, { threshold: this.threshold });
     }
@@ -76,13 +83,6 @@ export class Rule extends Lint.Rules.AbstractRule {
             typeof this.threshold === "number" && this.threshold >= Rule.MINIMUM_THRESHOLD;
         return super.isEnabled() && isThresholdValid;
     }
-
-    private get threshold(): number {
-        if (this.ruleArguments[0] !== undefined) {
-            return this.ruleArguments[0] as number;
-        }
-        return Rule.DEFAULT_THRESHOLD;
-    }
 }
 
 function walk(ctx: Lint.WalkContext<{ threshold: number }>): void {