Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Missing no-duplicate-key implementation #1599

Closed
michaeljota opened this issue Oct 5, 2016 · 6 comments
Closed

Missing no-duplicate-key implementation #1599

michaeljota opened this issue Oct 5, 2016 · 6 comments

Comments

@michaeljota
Copy link

Bug Report

  • TSLint version: 4.0.0-dev0
  • TypeScript version: 2.0.3
  • Running TSLint via: CLI

Actual behavior

Error:
            Could not find implementations for the following rules specified in the configuration:
            no-duplicate-key
            Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
            If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.

Expected behavior

To have a no-duplicate-key implementation

It's the rule no-duplicate-key have been remove or rename or something?

@adidahiya
Copy link
Contributor

adidahiya commented Oct 5, 2016

Yes, it was removed (#885) because this functionality is covered by the compiler now. Sorry I didn't get around to writing the changelog for v4.0.0-dev.0, but you can check out the milestone: https://github.com/palantir/tslint/milestone/26?closed=1

@michaeljota
Copy link
Author

Thanks! Will close this then. 😃

@dsifford
Copy link

dsifford commented Nov 1, 2016

@adidahiya How would one get around this issue if they were using the development branch + using "extends": ["tslint:latest"] in their tslint.json? Is that not possible?

@adidahiya
Copy link
Contributor

@dsifford do you mean 4.0.0-dev.0? It was removed from the built-in configurations in that release too... https://github.com/palantir/tslint/blob/4.0.0-dev.0/src/configs/recommended.ts

@dsifford
Copy link

dsifford commented Nov 1, 2016

@adidahiya Hm.. Let me try again in a bit and report back.

Here's my build from earlier this afternoon that failed after bumping up to @next: https://travis-ci.org/dsifford/academic-bloggers-toolkit/builds/172345309

And here's the commit (you'll see 4.0.0-dev.0 listed in the yarn.lock file): dsifford/academic-bloggers-toolkit@10ab0ba

Let me know if I'm missing something obvious (which is generally the case!)

Also, please extend my thanks to the rest of the Palantir team for all their work on this. Such a critical part of my workflow! 💯 👍

@dsifford
Copy link

dsifford commented Nov 2, 2016

@adidahiya Sorry for the delay.

This is an issue with tslint-microsoft-contrib and it appears to have been resolved in their master branch as of 11 days ago. microsoft/tslint-microsoft-contrib#304

All good now 👍

andypyrope added a commit to andypyrope/npm-vinyl-fs that referenced this issue Nov 10, 2017
Tests:
 - Remove two deprecated rules in tslint.json (palantir/tslint#1599 and palantir/tslint#661)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants