Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

unused variable rule shouldn't error on abstract methods with parameters #664

Merged
merged 2 commits into from
Sep 16, 2015
Merged

unused variable rule shouldn't error on abstract methods with parameters #664

merged 2 commits into from
Sep 16, 2015

Conversation

DickvdBrink
Copy link
Contributor

fixes #663

adidahiya
adidahiya reviewed Sep 16, 2015
View reviewed changes
src/rules/noUnusedVariableRule.ts
@@ -193,7 +193,13 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker {
}
}

// skip checking parameter declarations for abstract methods
// They can't have a body so parameters are always unused
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just simplify to a one-line comment (this will fix the lint failure as well)

// abstract methods can't have a body so their parameters are always unused

@DickvdBrink
Copy link
Contributor Author

Oops, sorry about that... I did ran the test and when I checked my commit I decided to change the comment... without executing the test again

adidahiya added a commit that referenced this pull request Sep 16, 2015
@adidahiya
Merge pull request #664 from DickvdBrink/abstract-method-parameters
5aaaff7 
unused variable rule shouldn't error on abstract methods with parameters
@adidahiya adidahiya merged commit 5aaaff7 into palantir:master Sep 16, 2015
@adidahiya
Copy link
Contributor

thanks @DickvdBrink!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused variable rule and abstract methods
2 participants
@DickvdBrink @adidahiya