Phase 1 - Refactor to support Rector 0.17 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can actually add comments
… to AssertLegacyTraitBase
…otPerformAssertionToNonAssertingTestRector in drupal-8-all-deprecations.php
…rupal 10.0 were on phpunit 9.x, so the setlist should be phpunit 9, not phpunit 10.
This was referenced Aug 16, 2023
Closed
bbrala
changed the title
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| return static function (\Rector\Config\RectorConfig $rectorConfig): void { | |||
| $rectorConfig->sets([ | |||
| PHPUnitSetList::PHPUNIT_91 | |||
| PHPUnitSetList::PHPUNIT_90 | |||
There was a problem hiding this comment.
@bbrala This feels like a regresssion, even though it probably is not.
Any idea why this change is required?
There was a problem hiding this comment.
The list for PHPUnit 9.1 has been deprecated and replaces with the 100 version. But, since core doesn't really support PhpUnit 10, it seems weird to add that list.
Its changes like this one: sebastianbergmann/phpunit#4087 which is a change to PHPUnit 10. Should core start using PHPUnit 10, then we might need this?
That was my thought process at least.
agentrickard
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This are all the changes that were needed from the stan-fails branch to work on rector 0.17.x. Cleaned up with readable commits. Also; we do not need: