Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl 17 filter by terms on drupal 8 demo #6

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

mcarmichael21
Copy link
Contributor

JIRA Ticket(s)

Description

Added ability to to filter by categories like Recipe Category, so that users can see how federated terms filters works.

Testing instructions

  1. vendor/bin/phing build install
  2. Visit /search-app and view Recipe Category and Dietary Needs filters when searching.

Relevant Screenshots/gifs:

screen shot 2018-08-27 at 7 11 34 am


Pull Request Guidelines

@mcarmichael21 mcarmichael21 self-assigned this Aug 27, 2018
Copy link
Contributor

@froboy froboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcarmichael21 this is fantastic, and I didn't even know these drush commands existed. Thanks!

<drush command="pm-uninstall" assume="yes">
<param>federated_terms</param>
</drush>
<drush command="sapi-c" assume="yes">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

<drush command="sapi-c" assume="yes">
<param>federated_search</param>
</drush>
<drush command="sapi-i" assume="yes">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 😱

@froboy froboy merged commit b31f33d into master Aug 29, 2018
@froboy froboy deleted the PL-17-Filter-by-terms-on-Drupal-8-Demo branch August 29, 2018 16:41
@ibakayoko ibakayoko mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants