Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select with ignore_log_data #128

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Fix select with ignore_log_data #128

merged 3 commits into from
Aug 5, 2019

Conversation

palkan
Copy link
Owner

@palkan palkan commented Jun 6, 2019 •
edited
Loading

What is the purpose of this pull request?

Fix #127 and improve ignore_log_data functionality.

What changes did you make? (overview)

  • Fixed with_log_data scope to include only the current table columns (Fixes latest release (v0.10.0) breaks db tests #127)
  • Avoid adding ignored_columns if ignore_log_data is false
  • Remove force_load_log_data
  • Remove adding with_log_data to associations
  • Expose Logidze settings via Rails.application.config.logidze

Checklist

  • I've added tests for this change
  • I've added a Changelog entry
  • I've updated a documentation (Readme)

@palkan palkan mentioned this pull request Jun 6, 2019
Closed
@palkan palkan mentioned this pull request Jul 4, 2019
Merged
@palkan palkan merged commit d754a25 into master Aug 5, 2019
@palkan palkan deleted the fix/select-with-ignore branch August 5, 2019 01:19
@palkan palkan mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

latest release (v0.10.0) breaks db tests
1 participant
@palkan