-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proxy support #8
Comments
Maybe we should default the proxy information, in the same way leiningen does |
I thought about it already. |
As I had the proxy values passing already working, I left it in. So the function where the proxy config is the really used looks like this: (defn resolve-dependencies
[still dependencies repositories proxy]
(classlojure/eval-in
(:alembic-classloader @still)
`(do
(require '[leiningen.core.classpath :as ~'cp])
(mapv
(fn [dep#]
(letfn [(apath# [^java.io.File f#] (.getAbsolutePath f#))]
{:coords dep#
:jar (-> dep# meta :file apath#)}))
(keys
(aether/resolve-dependencies
:coordinates '~(vec dependencies)
:repositories ~repositories
:proxy '~(or proxy (cp/get-proxy-settings) ))))))) What do you think ? |
I made as well a version which always uses the environment variables without a way to override the proxy configuration via function parameters. Let me know, which version you prefer and I send a new pull request. |
I think I would favour having the default picked up from the environment, and still being able to explicitly overide. |
OK. |
Fixed in 8ced4ed |
I am behind a corporate proxy, so the "distill" method does not manage to download dependencies.
I looked at the code, the aether/resolve-dependencies you use allows to specify a proxy.
So it just need to be passds through.
If I find some time I will fix it and send you a pull request
The text was updated successfully, but these errors were encountered: