Re-enable the typing github action
#2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to move forward with this just to unblock other work on flask-admin, but happy to hear thoughts retrospectively - especially if anyone catches anything I've missed here. |
Disables all of the flags that `--strict` adds, so that we can gradually pick away at them more easily over time.
* Install missing types for mypy * Use shapely>=1.8, which has the correct resolution for libgeos on darwin. * Use '-r tests.in' in `typing.in`, so that all packages are installed to aid in type resolution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion/stream of work: #2440
This turns back on the
typingcheck, with all of the '--strict' options disabled, and then makes the minimum set of code changes required to make the typing tests pass.Future patches will slowly work to re-enable each of the disabled mypy checks so that the burden of typing the codebase is a bit less overwhelming.
Also fixes running the test suite on macos with libgeos by pulling in an updated version of geoalchemy2.