Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bootstrap 2 and 3 #2474

Closed
wants to merge 4 commits into from
Closed

Remove bootstrap 2 and 3 #2474

wants to merge 4 commits into from

Conversation

samuelhwilliams
Copy link
Contributor

@samuelhwilliams samuelhwilliams commented Jul 23, 2024

Removes Bootstrap2 and Bootstrap3 themes, both of which are now comfortably replaced by Bootstrap4 (and, really, 5 when we add it).

We want to support add support for Bootstrap5 soon. This will probably be easier without the thought of having to support anything from bs2 and bs3.

@hasansezertasan
Copy link
Member

We want to support add support for Bootstrap5 soon. This will probably be easier without the thought of having to support anything from bs2 and bs3.

Yes and no, X-Editable doesn't work with BS5 😞.

Copy link
Member

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job 👍💯👍.

flask_admin/theme.py Show resolved Hide resolved
@samuelhwilliams samuelhwilliams closed this by deleting the head repository Jul 24, 2024
@samuelhwilliams
Copy link
Contributor Author

Ugh, deleted my fork unintentionally 🙃 I will re-open and merge, referencing this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants