Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registering w/o a password. #261

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Add support for registering w/o a password. #261

merged 1 commit into from
Jan 29, 2020

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jan 24, 2020

Continued integrating unified sign in into other features.

We use an un-guessable password (not an empty) one in the user DB record - this makes sure
we don't let folks log in w/o any password, and keeps the DB Column definition of 'non-null' the same.

Added "password" explicitly as a US_ENABLED_METHODS - this actually allows an admin to NOT allow password login - or to JUST use passwords with this new endpoint.

@jwag956 jwag956 self-assigned this Jan 24, 2020
@jwag956 jwag956 added this to the 3.4 milestone Jan 24, 2020
Continued integrating unified sign in into other features.

We use an un-guessable password (not an empty) one in the user DB record - this makes sure
we don't let folks log in w/o any password, and keeps the DB Column definition of 'non-null' the same.

Added "password" explicitly as a US_ENABLED_METHODS - this actually allows an admin to NOT allow password login - or to JUST use passwords with this new endpoint.
@jwag956 jwag956 merged commit 9a04581 into master Jan 29, 2020
@jwag956 jwag956 deleted the usregister branch January 29, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant