Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use shlex.quote for quoting shell arguments" #1543

Merged
merged 1 commit into from Apr 27, 2020
Merged

Conversation

@davidism
Copy link
Member

@davidism davidism commented Apr 27, 2020

This caused issues if the pager/editor command had options like less -FRSX, they would then get quoted as a single word rather than less then -FRSX.

shlex.quote doesn't seem to do the right thing on Windows cmd. Using shlex.split on the command first wouldn't help, as it would need to get re-joined and subprocess.list2cmdline is not an external API. Let's hold off until #1476 instead.

Reverts #1470
Closes #1514

This reverts commit e798f64.

This caused issues if the editor command (etc.) had options like
"less -FRSX" because they would then get quoted as a single word.
@davidism davidism added this to the 7.1.2 milestone Apr 27, 2020
@davidism davidism merged commit 25a3cb2 into 7.x Apr 27, 2020
12 checks passed
12 checks passed
Tests Build #20200427.1 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.8 Linux) Job Python 3.8 Linux succeeded
Details
Tests (Job Python 3.8 Mac) Job Python 3.8 Mac succeeded
Details
Tests (Job Python 3.8 Windows) Job Python 3.8 Windows succeeded
Details
Tests (Job Style) Job Style succeeded
Details
@davidism davidism deleted the revert-shlex-quote branch Apr 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant