Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bash shell completion version error with warning #2576

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

superatomic
Copy link
Contributor

Replaces instances of raise RuntimeError(...) with echo(..., err=True) in _check_version().

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@superatomic
Copy link
Contributor Author

#2581 should be merged first before this PR is merged.

@superatomic
Copy link
Contributor Author

It might be worth removing the warning when Bash is not on the system at all, so the behavior is more in line with Zsh and Fish.

@davidism
Copy link
Member

I'm not planning to change it more. This is geared towards people using it directly, not towards other build systems.

@davidism davidism marked this pull request as ready for review August 17, 2023 17:13
@davidism davidism merged commit a260ca6 into pallets:8.1.x Aug 17, 2023
10 checks passed
@superatomic
Copy link
Contributor Author

Makes sense. Thank you for your review and your work! I appreciate it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants