Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite Vary header when setting for cookie access #2317

Closed
davidism opened this issue May 23, 2017 · 2 comments · Fixed by #2322
Closed

Don't overwrite Vary header when setting for cookie access #2317

davidism opened this issue May 23, 2017 · 2 comments · Fixed by #2322

Comments

@davidism
Copy link
Member

If the Vary header is already set, the current session code just adds another header line. What it should do is update the existing header by splitting, adding the new option to the set, joining, and setting the new value. See Django's patch_vary_headers.

Related to #2288
@davidism
Copy link
Member Author

Current code is here:

flask/flask/sessions.py

Line 408 in e206764

response.headers.add('Vary', 'Cookie')

@nnja
Copy link
Contributor

nnja commented May 23, 2017

I'll work on this during pycon sprints.

nnja added a commit to nnja/flask that referenced this issue May 23, 2017
@nnja
Don't overwrite Vary header when setting for cookie access pallets#2317
464072d
@nnja nnja mentioned this issue May 23, 2017
Merged
nnja added a commit to nnja/flask that referenced this issue May 25, 2017
@nnja
Don't overwrite Vary header when setting for cookie access pallets#2317
e7cd68b
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't overwrite Vary header when setting for cookie access nnja/flask
2 participants
@davidism @nnja