Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teardown bug in FlaskClient #3157

Merged
merged 1 commit into from May 25, 2019

Conversation

@fantix
Copy link
Contributor

commented Apr 16, 2019

Entering a client preserves all context from being poped, but exiting only poped one preserved context. This PR pops all preserved context.

@davidism davidism force-pushed the fantix:fix-test-client-teardown branch from 39e1210 to 5b97002 May 25, 2019

@davidism davidism added the testing label May 25, 2019

@davidism davidism added this to the 1.1.0 milestone May 25, 2019

@davidism davidism force-pushed the fantix:fix-test-client-teardown branch from 5b97002 to a71c167 May 25, 2019

@davidism davidism merged commit 2c68f86 into pallets:master May 25, 2019

12 checks passed

Flask Build #20190525.4 succeeded
Details
Flask (Flask DocsHtml) Flask DocsHtml succeeded
Details
Flask (Flask Pypy3Linux) Flask Pypy3Linux succeeded
Details
Flask (Flask Python27Linux) Flask Python27Linux succeeded
Details
Flask (Flask Python27Windows) Flask Python27Windows succeeded
Details
Flask (Flask Python35Linux) Flask Python35Linux succeeded
Details
Flask (Flask Python36Linux) Flask Python36Linux succeeded
Details
Flask (Flask Python37Linux) Flask Python37Linux succeeded
Details
Flask (Flask Python37Mac) Flask Python37Mac succeeded
Details
Flask (Flask Python37Windows) Flask Python37Windows succeeded
Details
Flask (Flask VersionRange) Flask VersionRange succeeded
Details
Flask (FlaskOnNightly) FlaskOnNightly succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.