Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix teardown bug in FlaskClient #3157

Merged
merged 1 commit into from
May 25, 2019
Merged

Fix teardown bug in FlaskClient #3157

merged 1 commit into from
May 25, 2019

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Apr 16, 2019

Entering a client preserves all context from being poped, but exiting only poped one preserved context. This PR pops all preserved context.

@fantix fantix mentioned this pull request Apr 16, 2019
Merged
@davidism davidism added this to the 1.1.0 milestone May 25, 2019
@davidism davidism merged commit 2c68f86 into pallets:master May 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
@davidism
Copy link
Member

davidism commented Jul 1, 2022 •
edited
Loading

This was not actually a bug. stream_with_context preserves a context independently of with client, the context should remain until the stream ends or is closed. Either reading response.data or calling response.close() would be the correct fix to the linked issue.

reverted as part of #4666

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Testing errors when streaming
2 participants
@fantix @davidism