-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing block overrides in include tags causes unexpected behavior. #243
Comments
Reverted, going to be in next maintenance release. |
* Bugfix: Fix smartypants to 1.7.x to avoid the breaking changes in 1.8. (Issue #229) * Bugfix: Upgrade Jinja to 2.7.1 - this fixes pallets/jinja#243.
This reverts commit 832dbf6. Blocks that are inside included templates aren't overriden (see pallets/jinja#243)
The bug still exists. |
This bug was fixed. Originally #84 introduced block overrides in include tags and got merged later, but it has since broke some templates setup (recursion on duplicated block), hence this issue. Because the template behavior should not be changed, @mitsuhiko revert the patch. If you want to support block overrides, please make a new issue, and maybe a proposed working solution. |
It should be such easy to provide include with block overrides while keeping compatibility of current implementation of include just by using different template tag name:
does not override included blocks, while:
does the same. It's very strange that such functionality is not implemented for such a long time, knowing how Jinja2 is very powerful in most of features, in fact one of the best template engines around, not just for Python. Especially if there was actual patch done already. |
See #84 (comment) for details.
The text was updated successfully, but these errors were encountered: