Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unique filter #469

Closed
wants to merge 1 commit into from
Closed

Added unique filter #469

wants to merge 1 commit into from

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Aug 4, 2015

4 years ago I suggested to add a unique filter, along with some other new filters as part of #66. That pull request has been closed, after some parts of it got implemented independently. However, I just saw a similar request (#443) for excluding duplicates using filters. So I rebased my old patch, added tests and did some logical improvements, that it hopefully get merged now.

@@ -51,21 +51,24 @@ def environmentfilter(f):
return f


def make_attrgetter(environment, attribute):
def make_attrgetter(environment, attribute, lowercase=False):

This comment has been minimized.

This comment has been minimized.

@@ -51,21 +51,24 @@ def environmentfilter(f):
return f


def make_attrgetter(environment, attribute):
def make_attrgetter(environment, attribute, lowercase=False):

This comment has been minimized.

key = getter(item)
if key not in seen:
seen.add(key)
rv.append(item)

This comment has been minimized.

@davidism
Copy link
Member

davidism commented Apr 13, 2017

Needs a changelog entry.

@Talkless
Copy link

Talkless commented Apr 13, 2017

@snoack Are you yet interested in fixing this PR?

@davidism davidism mentioned this pull request Jul 5, 2017
@davidism
Copy link
Member

davidism commented Jul 5, 2017

Continued in #735

@davidism davidism closed this Jul 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants