Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictsort reverse #692

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Dictsort reverse #692

merged 2 commits into from
Jul 8, 2017

Conversation

dnmvisser
Copy link
Contributor

No description provided.

@ThiefMaster
Copy link
Member

Let's add a test for this in test_dictsort. It's just two lines :p
Also, mention it in CHANGES.

Oh, and it'd be great if you could rebase against the latest master and squash the commits into a single one. While this can be done while merging it's easy to forget, which results in a somewhat ugly git log.

@davidism davidism merged commit 711ad9d into pallets:master Jul 8, 2017
@dnmvisser dnmvisser deleted the dictsort_reverse branch August 5, 2017 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants