New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictsort reverse #692

Merged
merged 2 commits into from Jul 8, 2017

Conversation

3 participants
@dnmvisser
Contributor

dnmvisser commented Mar 9, 2017

No description provided.

@ThiefMaster

This comment has been minimized.

Show comment
Hide comment
@ThiefMaster

ThiefMaster Apr 5, 2017

Member

Let's add a test for this in test_dictsort. It's just two lines :p
Also, mention it in CHANGES.

Oh, and it'd be great if you could rebase against the latest master and squash the commits into a single one. While this can be done while merging it's easy to forget, which results in a somewhat ugly git log.

Member

ThiefMaster commented Apr 5, 2017

Let's add a test for this in test_dictsort. It's just two lines :p
Also, mention it in CHANGES.

Oh, and it'd be great if you could rebase against the latest master and squash the commits into a single one. While this can be done while merging it's easy to forget, which results in a somewhat ugly git log.

dnmvisser and others added some commits Mar 9, 2017

add test and changelog
use ignore_case function

@davidism davidism merged commit 711ad9d into pallets:master Jul 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dnmvisser dnmvisser deleted the dnmvisser:dictsort_reverse branch Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment